pyicu merge requestshttps://gitlab.pyicu.org/main/pyicu/-/merge_requests2022-10-24T08:39:20-07:00https://gitlab.pyicu.org/main/pyicu/-/merge_requests/144Bugfix: Only call _init_displayoptions() for ICU 72 and greater.2022-10-24T08:39:20-07:00Fredrik Roubertroubert@google.comBugfix: Only call _init_displayoptions() for ICU 72 and greater.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/113Move native extension inside module2022-01-24T18:22:45-08:00Andi VajdaMove native extension inside module*Created by: wyattanderson*
The goal here is to address this issue with `delocate`, so that we can internally distribute relocatable binary wheels for OS X:
https://github.com/matthew-brett/delocate/issues/12#issuecomment-246536098
...*Created by: wyattanderson*
The goal here is to address this issue with `delocate`, so that we can internally distribute relocatable binary wheels for OS X:
https://github.com/matthew-brett/delocate/issues/12#issuecomment-246536098
I've tested a little bit locally, but would love assistance testing more substantially. I'm not very familiar with Python packaging when it comes to native extensions.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/39ENH:Create universal wheel on PyPi for `pyicu`2021-05-26T05:20:19-07:00Andi VajdaENH:Create universal wheel on PyPi for `pyicu`*Created by: linwoodc3*
If this is too instructive, forgive me. Just wanted to require minimal effort from original author since this is me asking you to add something to your repository.
# Summary of Merge Request
@ovalhub, this...*Created by: linwoodc3*
If this is too instructive, forgive me. Just wanted to require minimal effort from original author since this is me asking you to add something to your repository.
# Summary of Merge Request
@ovalhub, this merge request creates a “Universal Wheel” to [resolve an issue on the MacOS where pyicu's inability to fully install via `pip install pyicu`](https://github.com/aboSamoor/polyglot/issues/80) causes an error with [`polyglot`](https://github.com/aboSamoor/polyglot), which is a multilingual NLP library created by @aboSamoor .
## Details of Request
Request @ovalhub accept merge request, and run the following commands to update the [PyICU PyPi packaging](https://pypi.python.org/pypi/PyICU/1.9.5). This will include a universal wheel in the `File` section.
The problem encountered and fix are [discussed in detail here](https://github.com/aboSamoor/polyglot/issues/80#issuecomment-266301717).
## What's the Change?
Just created a simple `setup.cfg` file as described in the [Universal Wheels section](https://packaging.python.org/distributing/#universal-wheels) of the **[Python Packaging User Guide](https://packaging.python.org/)**. The exact content of the simple setup.cfg [file is here](https://github.com/pypa/sampleproject/blob/master/setup.cfg).
## How to "update" your Packaging
After this file is in the master `pyicu` repository, you run the following commands, as described in the [Packaging User Guide](https://packaging.python.org/distributing/#packaging-your-project):
```bash
>>> cd pyicu
>>> python setup.py bdist_wheel --universal # create the universal wheel
>>> python setup.py bdist_wheel # creates platform specific wheel just in case
```
Now, the last step is just uploading the distribution to PyPi. If you use twine (recommended approach, see [here for security discussion](https://packaging.python.org/distributing/#upload-your-distributions)):
```bash
>>> twine upload dist/*
```
Or the `setuptools` alternative (not recommended, see [here for security discussion](https://packaging.python.org/distributing/#upload-your-distributions)):
```bash
>>> python setup.py sdist bdist_wheel upload
```
This should [solve one of the problems discussed in the `polyglot` issue](https://github.com/aboSamoor/polyglot/issues/80#issuecomment-266301717).https://gitlab.pyicu.org/main/pyicu/-/merge_requests/138Try to build wheels2021-04-01T14:51:24-07:00Andi VajdaTry to build wheels*Created by: abitrolly*
https://pypi.org/project/cibuildwheel/*Created by: abitrolly*
https://pypi.org/project/cibuildwheel/https://gitlab.pyicu.org/main/pyicu/-/merge_requests/136Fix build error on Python 3.9 for Windows2020-07-31T11:32:44-07:00Andi VajdaFix build error on Python 3.9 for Windows*Created by: cgohlke*
Fixes
```
_icu.cpp(209): error C2017: illegal escape sequence
_icu.cpp(209): error C2001: newline in constant
_icu.cpp(210): error C2146: syntax error: missing ')' before identifier 'PyObject_SetAttrString'
_i...*Created by: cgohlke*
Fixes
```
_icu.cpp(209): error C2017: illegal escape sequence
_icu.cpp(209): error C2001: newline in constant
_icu.cpp(210): error C2146: syntax error: missing ')' before identifier 'PyObject_SetAttrString'
_icu.cpp(210): error C2146: syntax error: missing ';' before identifier 'PyObject_SetAttrString'
_icu.cpp(212): error C2017: illegal escape sequence
_icu.cpp(212): error C2001: newline in constant
_icu.cpp(213): error C2146: syntax error: missing ')' before identifier 'PyObject_SetAttrString'
_icu.cpp(213): error C2146: syntax error: missing ';' before identifier 'PyObject_SetAttrString'
```https://gitlab.pyicu.org/main/pyicu/-/merge_requests/112Fix runtime `dlopen` crash on macos2019-11-12T16:40:29-08:00Andi VajdaFix runtime `dlopen` crash on macos*Created by: yursha*
Without this change `otool -L build/lib.macosx-10.14-x86_64-3.7/_icu.cpython-37m-darwin.so` doesn't show ICU system libraries as dependencies. As a result `pyicu` crashes at runtime on `dlopen`. With this change eve...*Created by: yursha*
Without this change `otool -L build/lib.macosx-10.14-x86_64-3.7/_icu.cpython-37m-darwin.so` doesn't show ICU system libraries as dependencies. As a result `pyicu` crashes at runtime on `dlopen`. With this change everything works just fine.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/85Include casemap.h in sdist2018-08-04T00:20:51-07:00Andi VajdaInclude casemap.h in sdist*Created by: cgohlke*
Fix PyICU-2.0.4.tar.gz on PyPI is missing casemap.h.*Created by: cgohlke*
Fix PyICU-2.0.4.tar.gz on PyPI is missing casemap.h.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/62use icu-config for cflags/ldflags2017-11-14T18:13:15-08:00Andi Vajdause icu-config for cflags/ldflags*Created by: pkit*
currently `icu-config` is used to set icu version
but it can also be used (if present) to properly set `CFLAGS` and `LDFLAGS`*Created by: pkit*
currently `icu-config` is used to set icu version
but it can also be used (if present) to properly set `CFLAGS` and `LDFLAGS`https://gitlab.pyicu.org/main/pyicu/-/merge_requests/52Fix str exception on setup.py for Python 32017-05-03T13:03:57-07:00Andi VajdaFix str exception on setup.py for Python 3*Created by: cenkalti*
In Python 3, `os.environ` values are already in `str` type. There is no need to wrap them with `str` function again.
When you do `str(s, 'ascii')` on a string it raises an exception:
```
TypeError: decoding s...*Created by: cenkalti*
In Python 3, `os.environ` values are already in `str` type. There is no need to wrap them with `str` function again.
When you do `str(s, 'ascii')` on a string it raises an exception:
```
TypeError: decoding str is not supported
```
I have removed the `str()` wrapper to fix this issue.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/47Fix Windows setup problems2017-04-10T12:01:13-07:00Andi VajdaFix Windows setup problems*Created by: amynbe*
Integrated fixes from #7 and #42 and #44
Also added c:/icu/lib64 lib path to Win LFLAGS as that's what exists in the latest icu version 58.*Created by: amynbe*
Integrated fixes from #7 and #42 and #44
Also added c:/icu/lib64 lib path to Win LFLAGS as that's what exists in the latest icu version 58.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/50fix compilation failure with ICU 532017-04-10T12:00:07-07:00Andi Vajdafix compilation failure with ICU 53*Created by: pixelb*
UDateRelativeDateTimeFormatterStyle is not available in ICU 53, but is in ICU 55*Created by: pixelb*
UDateRelativeDateTimeFormatterStyle is not available in ICU 53, but is in ICU 55https://gitlab.pyicu.org/main/pyicu/-/merge_requests/46Compile error on Windows2017-03-21T15:15:59-07:00Andi VajdaCompile error on Windows*Created by: amynbe*
*Created by: amynbe*
https://gitlab.pyicu.org/main/pyicu/-/merge_requests/42Update setup.py2017-03-21T15:14:42-07:00Andi VajdaUpdate setup.py*Created by: tcoyze*
I made a quick change to work for me. I was wondering what your thoughts were on this change from using sub_process.*Created by: tcoyze*
I made a quick change to work for me. I was wondering what your thoughts were on this change from using sub_process.https://gitlab.pyicu.org/main/pyicu/-/merge_requests/23Rename docs.py as _icu_docs.py2016-12-19T12:02:01-08:00Andi VajdaRename docs.py as _icu_docs.py*Created by: jwilk*
`docs` is a very generic name for a module that is installed into global namespace.
Let's rename it as something clearly PyICU-specific and private.
*Created by: jwilk*
`docs` is a very generic name for a module that is installed into global namespace.
Let's rename it as something clearly PyICU-specific and private.
https://gitlab.pyicu.org/main/pyicu/-/merge_requests/36Added missing conditionals around use of uscript features from newer ICU vers...2016-11-09T14:34:14-08:00Andi VajdaAdded missing conditionals around use of uscript features from newer ICU versions*Created by: kdparker*
Fixes #35 (I can run the full install with these changes active). Moved the uscript features up as the oldest version I could find them in was 51. Moved the codes down to 4.6 as the code within libicu states they ...*Created by: kdparker*
Fixes #35 (I can run the full install with these changes active). Moved the uscript features up as the oldest version I could find them in was 51. Moved the codes down to 4.6 as the code within libicu states they were added in 4.6https://gitlab.pyicu.org/main/pyicu/-/merge_requests/18Don't apply compatibility hack when PyPy (5.2) already is compatible.2016-05-23T01:02:56-07:00Andi VajdaDon't apply compatibility hack when PyPy (5.2) already is compatible.*Created by: ssbr*
Better datetime support is coming in 5.2, this workaround breaks compilation. Woohoo!
Sorry about the CREDITS edit, not sure where to put it. It's my employer's policy to try to keep copyright info up to date.
*Created by: ssbr*
Better datetime support is coming in 5.2, this workaround breaks compilation. Woohoo!
Sorry about the CREDITS edit, not sure where to put it. It's my employer's policy to try to keep copyright info up to date.